Initial Support for flavors #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Other than my suggestions this looks really good!
The new docker image will be built when we release a new hover version which is probably in the next days when #170 is confirmed to fix everything.
Contributor
Author
|
@jld3103 thanks, I have updated as suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As discussed in go-flutter-desktop/go-flutter#475 this is my attempt to implement application flavors for Hover. I tested on my MacBook and was able to build and run different application flavors with no problem. Additional testing might be needed for other platforms which I don not have access to.
I also believe a new docker image will need to be built in order to get this working for docker builds.