Fix some files not being included in windows-msi #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
commented
Nov 4, 2020
Comment on lines
+16
to
-23
| if len(hoverYaml) == 0 { | ||
| hoverYaml = "hover.yaml" | ||
| } | ||
| return hoverYaml | ||
| } | ||
|
|
||
| // SetDefaultFlavorFile sets the default hover.yaml | ||
| func SetDefaultHoverYamlFile() { | ||
| hoverYaml = "hover.yaml" | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
These changes were needed, because the config needed to be loaded for init-packaging. It removes the need to call SetDefaultHoverYamlFile().
Contributor
There was a problem hiding this comment.
Makes, sense. I was not aware that len returns 0 on a nil
Member
Author
There was a problem hiding this comment.
Strings are never nil they are just empty
provokateurin
commented
Nov 4, 2020
Comment on lines
-267
to
+284
| if buildOrRunHoverFlavor == "" { | ||
| config.SetDefaultHoverYamlFile() | ||
| } else { | ||
| if buildOrRunHoverFlavor != "" { |
GeertJohan
requested changes
Nov 21, 2020
provokateurin
force-pushed
the
fix/windows-msi-files-not-included
branch
from
97f014b to
af8014f
Compare
Closed
Contributor
|
Seems like both the changes mentioned by @GeertJohan has been fixed, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes go-flutter-desktop/go-flutter#533