-
Notifications
You must be signed in to change notification settings - Fork 54
osfs: add file.Sync() support #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a call to `file.Sync()` to `util.WriteFile()` (right before closing the file, so it should be functionally equivalent) to ensure test coverage. Fixes: Issue go-git#86
Also add CallLogger to mock file system to record file system calls. The current implementation only logs sync calls but can be extended as needed.
pjbgf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georg thanks for following up on this.
|
@pjbgf Thanks for the review. I've made the changes. Only For Then there's also |
|
@georg thanks for looking into this. Don't worry about the |
Adds a call to file.Sync() to util.WriteFile() (right before closing the file, so it should be functionally equivalent) to ensure test coverage.
This is a continuation of PR #126 and implements the suggested changes.
Fixes: #86
Closes: #126