-
Notifications
You must be signed in to change notification settings - Fork 847
Open
Description
If I call PlainClone(...) to recursively clone some repo via HTTPS, and provide CloneOptions.CABundle because the remote TLS cert is signed by a self-signed CA, and the remote repository includes submodules also hosted in the same way, the clone fails.
This is because the CABundle provided to PlainClone(...) is not propagated to the submodule initializations. In the places where the FetchOptions are initialized for the submodule clones (one, two), FetchOptions.CABundle is not populated.
It seems to me that
- a
CABundlefield could be added toSubmoduleUpdateOptions, - populated based on the
CloneOptionsat the point thatSubmoduleUpdateOptionsis instantiated inRepository.clone(...), which - would then allow the submodules'
FetchOptions.CABundleto be suitably populated for the submodule clones.
Thoughts?
Metadata
Metadata
Assignees
Labels
No labels