Skip to content

CABundle not propagated to submodule clones #1629

@ianwarnold

Description

@ianwarnold

If I call PlainClone(...) to recursively clone some repo via HTTPS, and provide CloneOptions.CABundle because the remote TLS cert is signed by a self-signed CA, and the remote repository includes submodules also hosted in the same way, the clone fails.

This is because the CABundle provided to PlainClone(...) is not propagated to the submodule initializations. In the places where the FetchOptions are initialized for the submodule clones (one, two), FetchOptions.CABundle is not populated.

It seems to me that

  1. a CABundle field could be added to SubmoduleUpdateOptions,
  2. populated based on the CloneOptions at the point that SubmoduleUpdateOptions is instantiated in Repository.clone(...), which
  3. would then allow the submodules' FetchOptions.CABundle to be suitably populated for the submodule clones.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions