A lot of global lock test errors

[wxiaoguang]

--- FAIL: TestLockAndDo (15.23s)
    --- FAIL: TestLockAndDo/redis (15.00s)
        globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis
        globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis

...
...
...
         globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis
        globallock_test.go:89: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:89
            	            				/opt/hostedtoolcache/go/1.23.2/x64/src/runtime/asm_amd64.s:1700
            	Error:      	Received unexpected error:
            	            	lock already taken, locked nodes: [0]
            	Test:       	TestLockAndDo/redis
        globallock_test.go:95: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:95
            	            				/home/runner/work/gitea/gitea/modules/globallock/globallock_test.go:43
            	Error:      	Not equal: 
            	            	expected: 1000
            	            	actual  : 776
            	Test:       	TestLockAndDo/redis
FAIL
coverage: 91.8% of statements
FAIL	code.gitea.io/gitea/modules/globallock	23.286s

[wolfogre]

How were these errors reproduced? Is it possible that the previous test was aborted and the lock was not released, and the test was restarted before the lock expired?

[lunny]

I cannot reproduce it on my local machine. macOS go1.23.2 run with TEST_REDIS_URL=redis://127.0.0.1:6379/15 go test -tags=sqlite -run=TestLockAndDo.

[wxiaoguang]

How were these errors reproduced? Is it possible that the previous test was aborted and the lock was not released, and the test was restarted before the lock expired?

No idea, I just caught it from github actions. https://github.com/go-gitea/gitea/actions/runs/11459790779/job/31885087438

[wxiaoguang]

It fails a lot, probability > 5% or 10%

[wxiaoguang]

The root problem is that the global lock (redis) implementation is not right. But I guess I won't spend more time on it. Even if the lock goes wrong, end users won't be hurt too much at the moment.