Skip to content

Use db.WithTx/WithTx2 instead of TxContext when possible #35130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

Use db.WithTx/WithTx2 instead of TxContext when possible #35130

merged 2 commits into from
Jul 22, 2025

Conversation

@lunny
Copy link
Member

@lunny lunny commented Jul 19, 2025 •
edited
Loading

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 19, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 19, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 19, 2025
delvh
delvh approved these changes Jul 20, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 20, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 22, 2025
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 22, 2025
@lunny lunny merged commit 65cd3f5 into go-gitea:main Jul 22, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jul 22, 2025
@lunny lunny deleted the lunny/use_withtx_if_possible branch July 22, 2025 17:02
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 22, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 23, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2e8e0d0 
* giteaofficial/main:
  Remove unused poetry.toml file (go-gitea#35143)
  Use db.WithTx/WithTx2 instead of TxContext when possible (go-gitea#35130)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@delvh delvh delvh approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @delvh @hiifong @GiteaBot