Skip to content

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 25, 2025

Fix #35744 by reverting #18491

  • "OpenID" options don't mean "OAuth2Client" options
  • "OAuth2(server)" options don't mean "OAuth2Client" options

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 25, 2025
@wxiaoguang wxiaoguang changed the title Revert #18491 Revert #18491, fix oauth2 client link account Oct 25, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2025
@wxiaoguang
Copy link
Contributor Author

Doesn't block 1.25.0

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 26, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 26, 2025
@lunny lunny enabled auto-merge (squash) October 26, 2025 20:57
@lunny lunny merged commit 2f309b8 into go-gitea:main Oct 26, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 26, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 26, 2025
Fix go-gitea#35744 by reverting go-gitea#18491

* "OpenID" options don't mean "OAuth2Client" options
* "OAuth2(server)" options don't mean "OAuth2Client" options
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 26, 2025
lunny pushed a commit that referenced this pull request Oct 26, 2025
Backport #35745 by @wxiaoguang

Fix #35744 by reverting #18491

* "OpenID" options don't mean "OAuth2Client" options
* "OAuth2(server)" options don't mean "OAuth2Client" options

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang deleted the revert-oidc-linkaccount branch October 27, 2025 12:37
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 30, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Revert go-gitea#18491, fix oauth2 client link account (go-gitea#35745)
  Upgrade go mail to 0.7.2 (go-gitea#35748)
  [skip ci] Updated translations via Crowdin
  Support actions and reusable workflows from private repos (go-gitea#32562)
  Use git model to detect whether branch exist instead of gitrepo method (go-gitea#35459)
  Fix shutdown waitgroup panic (go-gitea#35676)
  Intorduce "config edit-ini" sub command to help maintaining INI config file (go-gitea#35735)
  Improve online runner check (go-gitea#35722)
  Make "update file" API can create a new file when SHA is not set (go-gitea#35738)
  Fix review request webhook bug (go-gitea#35339) (go-gitea#35723)
  Misc tool tweaks (go-gitea#35734)
  Update dependencies (go-gitea#35733)
  Make external iframe render work (go-gitea#35730)
  Remove mermaid margin workaround (go-gitea#35732)

# Conflicts:
#	models/user/user.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oauth2 Provider must be enabled for Account Linking by login to work on Oauth2 Client

4 participants