Skip to content

Make ACME email optional #35849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

Make ACME email optional #35849

merged 2 commits into from
Nov 4, 2025
+0 −3

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 4, 2025 •
edited
Loading

Fix a regression from #33668

Fix #35847

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 4, 2025
@wxiaoguang wxiaoguang mentioned this pull request Nov 4, 2025
Closed
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Nov 4, 2025

According to the example comment:

;; Email used for the ACME registration service
;; Can be left blank to initialize at first run and use the cached value
;ACME_EMAIL =

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 4, 2025
@lunny lunny enabled auto-merge (squash) November 4, 2025 17:47
@lunny lunny merged commit a0f492d into go-gitea:main Nov 4, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 4, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 4, 2025
@wxiaoguang @GiteaBot
Make ACME email optional (go-gitea#35849)
d2e2883 
Fix a regression from go-gitea#33668

Fix go-gitea#35847
@GiteaBot GiteaBot mentioned this pull request Nov 4, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Nov 4, 2025
lunny pushed a commit that referenced this pull request Nov 4, 2025
@GiteaBot @wxiaoguang
Make ACME email optional (#35849) (#35857)
7ea9722 
Backport #35849 by @wxiaoguang

Fix a regression from #33668

Fix #35847

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang deleted the fix-acme-email branch November 5, 2025 01:22
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Breaking change in a 'patch' release

4 participants

@wxiaoguang @lunny @silverwind @GiteaBot