Skip to content

Shorten page title in file view #17987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Shorten page title in file view #17987

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61eaa6f
Shorten page title in file view
silverwind Dec 14, 2021
47478c4
Merge branch 'main' into filename-title
lunny Dec 15, 2021
006422c
Merge branch 'main' into filename-title
lunny Dec 15, 2021
323c471
Merge branch 'main' into filename-title
wxiaoguang Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion routers/web/repo/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ func renderDirectory(ctx *context.Context, treeLink string) {
return
}

if ctx.Repo.TreePath != "" {
ctx.Data["Title"] = ctx.Tr("repo.file.title", ctx.Repo.Repository.Name+"/"+path.Base(ctx.Repo.TreePath), ctx.Repo.RefName)
}

// 3 for the extensions in exts[] in order
// the last one is for a readme that doesn't
// strictly match an extension
Expand Down Expand Up @@ -374,7 +378,7 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st
}
defer dataRc.Close()

ctx.Data["Title"] = ctx.Data["Title"].(string) + " - " + ctx.Tr("repo.file.title", ctx.Repo.TreePath, ctx.Repo.RefName)
ctx.Data["Title"] = ctx.Tr("repo.file.title", ctx.Repo.Repository.Name+"/"+path.Base(ctx.Repo.TreePath), ctx.Repo.RefName)

fileSize := blob.Size()
ctx.Data["FileIsSymlink"] = entry.IsLink()
Expand Down