Skip to content

Add password length check on install page #25491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add password length check on install page #25491

wants to merge 2 commits into from

Conversation

@earl-warren
Copy link
Contributor

@earl-warren earl-warren commented Jun 24, 2023

  • Resolves #271
  • Ensure that the adminstrator password is at least MIN_PASSWORD_LENGTH.

@Gusted @earl-warren
Add password length check on install page
582aec8 
- Resolves go-gitea#271
- Ensure that the adminstrator password is at least `MIN_PASSWORD_LENGTH`.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 24, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 24, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. backport/v1.20 labels Jun 24, 2023
techknowlogick
techknowlogick requested changes Jun 24, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Could you add the min length the the html template too, so that it alerts users before they submit the form. Note that if they choose not to create an admin user then the restriction would need to be added dynamically.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Jun 24, 2023
@yardenshoham yardenshoham removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 24, 2023
@earl-warren
Copy link
Contributor Author

earl-warren commented Sep 4, 2023

I'll re-open when and if these additional improvements are implemented. In the meantime if someone is motivated to do the work they are welcome to take this over.

@earl-warren earl-warren closed this Sep 4, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick requested changes

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@earl-warren @lunny @techknowlogick @delvh @yardenshoham @GiteaBot @Gusted