Fix ldap admin privileges update bug #27051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
Member
|
Could you add some tests? |
silverwind
approved these changes
Sep 16, 2023
GiteaBot
added
lgtm/need 1
Member
Author
|
@lng2020, I don't have time to write test cases. Could you help me implement it? |
Member
Author
Writing tests for this function is a bit difficult. |
Member
|
should we backport it? |
6543
approved these changes
Oct 1, 2023
GiteaBot
added
lgtm/done
6543
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user does not set a username lookup condition, LDAP will get an empty string
""for the user, hence the following codeThe user presence determination will always be nonexistent, so updates to user information will never be performed.
Fix #27049