Skip to content

Fix missing Close when error occurs and abused connection pool (#35658) #35670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2025
Merged

Fix missing Close when error occurs and abused connection pool (#35658) #35670

merged 6 commits into from
Oct 15, 2025

Conversation

wxiaoguang
Copy link
Contributor

Backport #35658

@wxiaoguang
fix
c11aadd 
# Conflicts:
#	go.sum
#	tests/integration/git_lfs_ssh_test.go
@wxiaoguang
fix httplib
5471702
@wxiaoguang
fix backport
46b0f14
@GiteaBot GiteaBot added this to the 1.25.0 milestone Oct 15, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 15, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/dependencies labels Oct 15, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2025
@silverwind silverwind added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 15, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) October 15, 2025 09:39
@wxiaoguang wxiaoguang merged commit 53a2aae into go-gitea:release/v1.25 Oct 15, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-lfs-ssh-backport branch October 15, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @silverwind @GiteaBot