Skip to content

Fix diff blob excerpt expansion #35922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2025
Merged

Fix diff blob excerpt expansion #35922

merged 3 commits into from
Nov 14, 2025
+171 −33

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 11, 2025

And add comments and tests

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 11, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 11, 2025
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Nov 11, 2025
@silverwind
Copy link
Member

silverwind commented Nov 12, 2025

It won't fix #35252, right?

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Nov 12, 2025

It won't fix #35252, right?

Won't

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 12, 2025
@wxiaoguang wxiaoguang requested a review from a team November 14, 2025 01:52
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2025
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 14, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 14, 2025 03:53
@wxiaoguang wxiaoguang merged commit 0fb3be7 into go-gitea:main Nov 14, 2025
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 14, 2025
@wxiaoguang wxiaoguang deleted the fix-diff-expand branch November 14, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wxiaoguang @silverwind @lunny @Zettat123 @GiteaBot