Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions models/issues/pull_list.go
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,26 @@ func (prs PullRequestList) LoadReviews(ctx context.Context) (ReviewList, error)

// HasMergedPullRequestInRepo returns whether the user(poster) has merged pull-request in the repo
func HasMergedPullRequestInRepo(ctx context.Context, repoID, posterID int64) (bool, error) {
return db.GetEngine(ctx).
return HasMergedPullRequestInRepoBefore(ctx, repoID, posterID, 0, 0)
}

// HasMergedPullRequestInRepoBefore returns whether the user has a merged PR before a timestamp (0 = no limit)
func HasMergedPullRequestInRepoBefore(ctx context.Context, repoID, posterID, beforeUnix, excludePullID int64) (bool, error) {
sess := db.GetEngine(ctx).
Join("INNER", "pull_request", "pull_request.issue_id = issue.id").
Where("repo_id=?", repoID).
And("poster_id=?", posterID).
And("is_pull=?", true).
And("pull_request.has_merged=?", true).
And("pull_request.has_merged=?", true)

if beforeUnix > 0 {
sess.And("pull_request.merged_unix < ?", beforeUnix)
}
if excludePullID > 0 {
sess.And("pull_request.id != ?", excludePullID)
}

return sess.
Select("issue.id").
Limit(1).
Get(new(Issue))
Expand Down
30 changes: 30 additions & 0 deletions models/repo/release.go
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,36 @@ func GetLatestReleaseByRepoID(ctx context.Context, repoID int64) (*Release, erro
return rel, nil
}

// GetPreviousPublishedRelease returns the most recent published release created before the provided release.
func GetPreviousPublishedRelease(ctx context.Context, repoID int64, current *Release) (*Release, error) {
cond := builder.NewCond().
And(builder.Eq{"repo_id": repoID}).
And(builder.Eq{"is_draft": false}).
And(builder.Eq{"is_prerelease": false}).
And(builder.Eq{"is_tag": false}).
And(builder.Or(
builder.Lt{"created_unix": current.CreatedUnix},
builder.And(
builder.Eq{"created_unix": current.CreatedUnix},
builder.Lt{"id": current.ID},
),
))

rel := new(Release)
has, err := db.GetEngine(ctx).
Desc("created_unix", "id").
Where(cond).
Get(rel)
if err != nil {
return nil, err
}
if !has {
return nil, ErrReleaseNotExist{0, "previous"}
}

return rel, nil
}

type releaseMetaSearch struct {
ID []int64
Rel []*Release
Expand Down
38 changes: 38 additions & 0 deletions models/repo/release_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"testing"

"code.gitea.io/gitea/models/unittest"
"code.gitea.io/gitea/modules/timeutil"

"github.com/stretchr/testify/assert"
)
Expand Down Expand Up @@ -37,3 +38,40 @@ func Test_FindTagsByCommitIDs(t *testing.T) {
assert.Equal(t, "delete-tag", rels[1].TagName)
assert.Equal(t, "v1.0", rels[2].TagName)
}

func TestGetPreviousPublishedRelease(t *testing.T) {
assert.NoError(t, unittest.PrepareTestDatabase())

current := unittest.AssertExistsAndLoadBean(t, &Release{ID: 8})
prev, err := GetPreviousPublishedRelease(t.Context(), current.RepoID, current)
assert.NoError(t, err)
assert.EqualValues(t, 7, prev.ID)
}

func TestGetPreviousPublishedRelease_NoPublishedCandidate(t *testing.T) {
assert.NoError(t, unittest.PrepareTestDatabase())

repoID := int64(1)
draft := &Release{
RepoID: repoID,
PublisherID: 1,
TagName: "draft-prev",
LowerTagName: "draft-prev",
IsDraft: true,
CreatedUnix: timeutil.TimeStamp(2),
}
current := &Release{
RepoID: repoID,
PublisherID: 1,
TagName: "published-current",
LowerTagName: "published-current",
CreatedUnix: timeutil.TimeStamp(3),
}

err := InsertReleases(t.Context(), draft, current)
assert.NoError(t, err)

_, err = GetPreviousPublishedRelease(t.Context(), repoID, current)
assert.Error(t, err)
assert.True(t, IsErrReleaseNotExist(err))
}
8 changes: 8 additions & 0 deletions options/locale/locale_en-US.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2751,6 +2751,14 @@ release.add_tag_msg = Use the title and content of release as tag message.
release.add_tag = Create Tag Only
release.releases_for = Releases for %s
release.tags_for = Tags for %s
release.generate_notes = Generate release notes
release.generate_notes_desc = Automatically add merged pull requests and a changelog link for this release.
release.previous_tag = Previous tag
release.previous_tag_auto = Auto
release.generate_notes_tag_not_found = Tag "%s" does not exist in this repository.
release.generate_notes_no_base_tag = No previous tag found to generate release notes.
release.generate_notes_target_not_found = The release target "%s" cannot be found.
release.generate_notes_missing_tag = Enter a tag name to generate release notes.
branch.name = Branch Name
branch.already_exists = A branch named "%s" already exists.
Expand Down
48 changes: 44 additions & 4 deletions routers/web/repo/release.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"code.gitea.io/gitea/models/unit"
user_model "code.gitea.io/gitea/models/user"
"code.gitea.io/gitea/modules/git"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/markup/markdown"
"code.gitea.io/gitea/modules/optional"
"code.gitea.io/gitea/modules/setting"
Expand Down Expand Up @@ -390,6 +391,38 @@ func NewRelease(ctx *context.Context) {
ctx.HTML(http.StatusOK, tplReleaseNew)
}

// GenerateReleaseNotes builds release notes content for the given tag and base.
func GenerateReleaseNotes(ctx *context.Context) {
form := web.GetForm(ctx).(*forms.GenerateReleaseNotesForm)

if ctx.HasError() {
ctx.JSONError(ctx.GetErrMsg())
return
}

result, err := release_service.GenerateReleaseNotes(ctx, ctx.Repo.Repository, ctx.Repo.GitRepo, release_service.GenerateReleaseNotesOptions{
TagName: form.TagName,
Target: form.Target,
PreviousTag: form.PreviousTag,
})
if err != nil {
if errTr := util.ErrorAsTranslatable(err); errTr != nil {
ctx.JSONError(errTr.Translate(ctx.Locale))
} else {
log.Error("GenerateReleaseNotes: %v", err)
ctx.JSON(http.StatusInternalServerError, map[string]any{
"errorMessage": ctx.Tr("error.occurred"),
})
}
return
}

ctx.JSON(http.StatusOK, map[string]any{
"content": result.Content,
"previous_tag": result.PreviousTag,
})
}

// NewReleasePost response for creating a release
func NewReleasePost(ctx *context.Context) {
newReleaseCommon(ctx)
Expand Down Expand Up @@ -518,11 +551,13 @@ func NewReleasePost(ctx *context.Context) {

// EditRelease render release edit page
func EditRelease(ctx *context.Context) {
newReleaseCommon(ctx)
if ctx.Written() {
return
}

ctx.Data["Title"] = ctx.Tr("repo.release.edit_release")
ctx.Data["PageIsReleaseList"] = true
ctx.Data["PageIsEditRelease"] = true
ctx.Data["IsAttachmentEnabled"] = setting.Attachment.Enabled
upload.AddUploadContext(ctx, "release")

tagName := ctx.PathParam("*")
rel, err := repo_model.GetRelease(ctx, ctx.Repo.Repository.ID, tagName)
Expand Down Expand Up @@ -563,8 +598,13 @@ func EditRelease(ctx *context.Context) {
// EditReleasePost response for edit release
func EditReleasePost(ctx *context.Context) {
form := web.GetForm(ctx).(*forms.EditReleaseForm)

newReleaseCommon(ctx)
if ctx.Written() {
return
}

ctx.Data["Title"] = ctx.Tr("repo.release.edit_release")
ctx.Data["PageIsReleaseList"] = true
ctx.Data["PageIsEditRelease"] = true

tagName := ctx.PathParam("*")
Expand Down
1 change: 1 addition & 0 deletions routers/web/web.go
Original file line number Diff line number Diff line change
Expand Up @@ -1406,6 +1406,7 @@ func registerWebRoutes(m *web.Router) {
m.Group("/releases", func() {
m.Get("/new", repo.NewRelease)
m.Post("/new", web.Bind(forms.NewReleaseForm{}), repo.NewReleasePost)
m.Post("/generate-notes", web.Bind(forms.GenerateReleaseNotesForm{}), repo.GenerateReleaseNotes)
m.Post("/delete", repo.DeleteRelease)
m.Post("/attachments", repo.UploadReleaseAttachment)
m.Post("/attachments/remove", repo.DeleteAttachment)
Expand Down
13 changes: 13 additions & 0 deletions services/forms/repo_form.go
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,19 @@ func (f *NewReleaseForm) Validate(req *http.Request, errs binding.Errors) bindin
return middleware.Validate(errs, ctx.Data, f, ctx.Locale)
}

// GenerateReleaseNotesForm retrieves release notes recommendations.
type GenerateReleaseNotesForm struct {
TagName string `form:"tag_name" binding:"Required;GitRefName;MaxSize(255)"`
Target string `form:"tag_target" binding:"MaxSize(255)"`
PreviousTag string `form:"previous_tag" binding:"MaxSize(255)"`
}

// Validate validates the fields
func (f *GenerateReleaseNotesForm) Validate(req *http.Request, errs binding.Errors) binding.Errors {
ctx := context.GetValidateContext(req)
return middleware.Validate(errs, ctx.Data, f, ctx.Locale)
}

// EditReleaseForm form for changing release
type EditReleaseForm struct {
Title string `form:"title" binding:"Required;MaxSize(255)"`
Expand Down
Loading