Fix oauth2 session gob register #36017
Merged
+22
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-oauth2-gob
branch
from
baf88fb to
7900b6c
Compare
wxiaoguang
force-pushed
the
fix-oauth2-gob
branch
from
7900b6c to
9829dac
Compare
Contributor
Author
|
Upstream fix: https://gitea.com/go-chi/session/pulls/11 |
wxiaoguang
force-pushed
the
fix-oauth2-gob
branch
2 times, most recently
from
f14a5bb to
4408afe
Compare
wxiaoguang
force-pushed
the
fix-oauth2-gob
branch
2 times, most recently
from
e2e7a5a to
d050b03
Compare
wxiaoguang
force-pushed
the
fix-oauth2-gob
branch
from
d050b03 to
e2cfadc
Compare
lunny
approved these changes
Nov 25, 2025
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Nov 26, 2025
| Domain: setting.SessionConfig.Domain, | ||
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create session middleware: %w", err) |
Member
There was a problem hiding this comment.
I'm not sure if the old or the new version of this error message is better.
I think I prefer the old one.
Contributor
Author
There was a problem hiding this comment.
This is the old one:
GiteaBot
added
lgtm/done
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Nov 26, 2025
* origin/main: Fix actions lint (go-gitea#36029) Fix oauth2 session gob register (go-gitea#36017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gob.Registermust be called before SessionerFix #36016