fix: Exclude code expansion arrows when DiffBlobExcerptData is not available. #36060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
Contributor
|
Although it "fixes" (no panic), but I don't think the fix is right.
The rendered conversation should have no "blob excerpt expand button". |
Contributor
|
The fix should be: - {{if $.root.AfterCommitID}}
+ {{if $diffBlobExcerptData}}And update the comments accordingly: 
|
lunny
added
type/bug
skip-changelog
github-actions
bot
added
the
modifies/templates
brymut
force-pushed
the
fix/include-diffBlobExcerptData-in-pull-conv
branch
from
58f7ae5 to
3e4f434
Compare
Contributor
Author
|
Apologies to the delay, updated |
lunny
approved these changes
Dec 3, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Dec 3, 2025
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
approved these changes
Dec 3, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
removed
the
reviewed/wait-merge
Contributor
|
The title and description need to be updated |
brymut
changed the title
Contributor
Author
done |
silverwind
approved these changes
Dec 5, 2025
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 6, 2025
* giteaofficial/main: Disable matchBrackets in monaco (go-gitea#36089) Update JS deps (go-gitea#36091) fix: Exclude code expansion arrows when DiffBlobExcerptData is not available. (go-gitea#36060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #35994
Do not render code expansion arrows when
DiffBlobExcerptDatais not available (code file preview, pull conversation diff comment).