Skip to content

Conversation

@tboerger
Copy link
Member

@tboerger tboerger commented Nov 3, 2016

I have integrated all dependencies with govendor and also updated the travis configuration since we don't need to download the dependencies anymore. This also fixes #29.

.travis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't this be written as instead?

go test -v race -cover -coverprofile coverage.out $(go list ./... | grep -v /vendor/)

Or do we need to split them up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, cannot use test profile flag with multiple packages

@andreynering
Copy link
Contributor

andreynering commented Nov 3, 2016

You forgot to vendor test packages. See the Travis output:

models/models_test.go:10:2: cannot find package "github.com/smartystreets/goconvey/convey" in any of:
    /home/travis/gopath/src/github.com/go-gitea/gitea/vendor/github.com/smartystreets/goconvey/convey (vendor tree)
    /home/travis/.gimme/versions/go1.6.linux.amd64/src/github.com/smartystreets/goconvey/convey (from $GOROOT)
    /home/travis/gopath/src/github.com/smartystreets/goconvey/convey (from $GOPATH)

@tboerger
Copy link
Member Author

tboerger commented Nov 3, 2016

You forgot to vendor test packages. See the Trivis output

Working on it.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 3, 2016
@tboerger
Copy link
Member Author

tboerger commented Nov 3, 2016

Ready for review/merge

@bkcsoft
Copy link
Member

bkcsoft commented Nov 4, 2016

LGTM

@tboerger
Copy link
Member Author

tboerger commented Nov 4, 2016

Rebased

@lunny
Copy link
Member

lunny commented Nov 4, 2016

LGTM

@lunny lunny merged commit 4a5faec into master Nov 4, 2016
@tboerger tboerger deleted the vendoring branch November 4, 2016 08:23
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
* Fix parsing bug in GetTagInfos

* Comment
@fakuivan fakuivan mentioned this pull request Jul 17, 2019
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate dependency manager

5 participants