Skip to content

Conversation

@ldsink
Copy link
Contributor

@ldsink ldsink commented Dec 17, 2019

"登陆" is typo, which means disembark.
the correct one in chinese is “登录”.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 17, 2019
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 17, 2019
@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #9382 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9382      +/-   ##
=========================================
+ Coverage    41.5%   41.5%   +<.01%     
=========================================
  Files         569     569              
  Lines       74305   74305              
=========================================
+ Hits        30837   30844       +7     
+ Misses      39626   39621       -5     
+ Partials     3842    3840       -2
Impacted Files Coverage Δ
modules/indexer/code/indexer.go 44.73% <0%> (-10.53%) ⬇️
modules/repository/repo.go 33.55% <0%> (-1.98%) ⬇️
modules/migrations/migrate.go 24.21% <0%> (-1.58%) ⬇️
models/webhook.go 69.39% <0%> (-1.07%) ⬇️
modules/migrations/gitea.go 9.03% <0%> (-0.64%) ⬇️
models/repo.go 48.2% <0%> (+0.1%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
models/error.go 33.2% <0%> (+1.11%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️
modules/task/migrate.go 28.94% <0%> (+3.94%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7e4cc...8547c21. Read the comment docs.

Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust lunnys chinese ;)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2019
@zeripath zeripath merged commit 412679f into go-gitea:master Dec 17, 2019
@ldsink ldsink deleted the typo branch December 17, 2019 16:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants