Skip to content

Conversation

@guillep2k
Copy link
Member

Just a couple of defer prepareTestEnv(t)() I've just spotted.

@techknowlogick techknowlogick added this to the 1.12.0 milestone Jan 21, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2020
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #9906 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9906      +/-   ##
==========================================
+ Coverage    42.3%   42.31%   +<.01%     
==========================================
  Files         607      607              
  Lines       79353    79353              
==========================================
+ Hits        33573    33578       +5     
+ Misses      41639    41636       -3     
+ Partials     4141     4139       -2
Impacted Files Coverage Δ
modules/queue/workerpool.go 41.2% <0%> (-2.58%) ⬇️
models/gpg_key.go 55.03% <0%> (-0.56%) ⬇️
models/repo.go 49.89% <0%> (+0.13%) ⬆️
services/pull/patch.go 69.81% <0%> (+1.88%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️
modules/process/manager.go 78.31% <0%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939d26e...739e9ff. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
@guillep2k
Copy link
Member Author

Maybe add "skip-changelog" to this.

@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 21, 2020
@6543
Copy link
Member

6543 commented Jan 21, 2020

Ping lgtm

@sapk sapk merged commit 8da863e into go-gitea:master Jan 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants