fix table schema and table catalog mixup#14
Merged
jinzhu merged 1 commit intogo-gorm:masterfrom Oct 22, 2020
asmeikal:master
Merged
fix table schema and table catalog mixup#14jinzhu merged 1 commit intogo-gorm:masterfrom asmeikal:master
jinzhu merged 1 commit intogo-gorm:masterfrom
asmeikal:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
My previous PR mixed up
table_schemaandtable_catalog. Inpostgres, the current database is stored intable_catalog, while inmysqlit's stored intable_schema. I mixed them up while opening the two PRs.Right now, the
ColumnTypesimplementation forpostgresreturns an empty list of columns. This PR fixes this.The tests I were running were not covering the case where no column was found. I fixed them here: go-gorm/playground#183
I'm sorry for the mistake.