Add logging for clickhouse query summary #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Civil
approved these changes
May 14, 2021
Member
Civil
left a comment
Civil
left a comment
There was a problem hiding this comment.
I only wonder if it's "free" on Clickhouse side and it won't be better to make this either sampled or configurable.
Felixoid
force-pushed
the
clickhouse-summary
branch
from
23104ed to
abae38a
Compare
Felixoid
force-pushed
the
clickhouse-summary
branch
from
abae38a to
94be74f
Compare
Collaborator
Author
|
Valid question. The statistics themselves are calculated for each query in any case. Then they are written to The header |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about unmarshalling, but the rest works fine