Skip to content

fix(index): ignore wildcard-min-distance when amount of nodes is 1 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(index): ignore wildcard-min-distance when amount of nodes is 1 #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion finder/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,12 @@ func (idx *IndexFinder) validatePlainQuery(query string, wildcardMinDistance int

var maxDist = where.MaxWildcardDistance(query)

if maxDist != -1 && maxDist < wildcardMinDistance {
// If the amount of nodes in a plain query is equal to 1,
// then make an exception
// This allows to check which root nodes exist
moreThanOneNode := strings.Count(query, ".") >= 1

if maxDist != -1 && maxDist < wildcardMinDistance && moreThanOneNode {
return errs.NewErrorWithCode("query has wildcards way too early at the start and at the end of it", http.StatusBadRequest)
}

Expand Down
10 changes: 9 additions & 1 deletion tests/wildcard_min_distance/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,12 @@ timeout = "1h"
targets = [
"*.*",
]
error_regexp = "^400: query has wildcards way too early at the start and at the end of it"
error_regexp = "^400: query has wildcards way too early at the start and at the end of it"

[[test.render_checks]]
from = "rnow-10"
until = "rnow+1"
timeout = "1h"
targets = [
"*",
]
Loading