Update generated files to use latest versions of compilers #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use vtproto@0.3.0 and protobuf@1.28.0 for generated files Also enable all features that vtproto provides
Member
Author
|
That's what I've talked about in the issue for go-carbon. Since the initial release and generation, vtproto implemented a bunch of new stuff, like reflect-less UnmarshalVT functions, Custom object Pool, etc. that seems to be extremely useful and should dramatically increase performance compared to what was in v2 tag. |
deniszh
approved these changes
Jun 22, 2022
Member
|
thanks, I will try to test it on go-carbon sometime next week on prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use vtproto@0.3.0 and protobuf@1.28.0 for generated files
Also enable all features that vtproto provides