sd etcd register/deregister implementation#299
Conversation
|
I think I see my issue in client_test.go. When I am testing locally it is more like an integration test because I am hitting a locally running etcd session. I need to get my stubs/mocks in order so I can effectively unit test. |
|
I have implemented all I can think of. The test suite could definitely use some more love eventually. |
| if s.Value == "" { | ||
| return ErrNoValue | ||
| } | ||
| if _, err := c.keysAPI.Create(context.Background(), s.Key, s.Value); err != nil { |
There was a problem hiding this comment.
Why context.Background() instead of c.ctx?
|
Sorry it took me so long to hop on this, thanks very much for the contribution! Lots of nits in there, but one big question about the presence of |
|
|
||
| func (c *fakeClient) WatchPrefix(prefix string, responseChan chan *stdetcd.Response) {} | ||
|
|
||
| func (c *fakeClient) Register(*Service) error { |
There was a problem hiding this comment.
Also removed pointer as parameter in this interface satisfying function declaration
|
The build process seems to be having issues around go getting openzipkin and opentracing. Im running out of mana so Im gonna call it for the day. Im not sure Ill have the access needed to address these build issues. |
|
re: the OpenTracing stuff, that's opentracing/basictracer-go#31
To convey this intent, how about changing |
2 participants
@peterbourgon PR started for discussion and code review.