Skip to content

Transports and contexts #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbourgon merged 1 commit into from
Jul 1, 2016
+3 −6
Merged

Transports and contexts #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions transport/grpc/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ func ServerErrorLogger(logger log.Logger) ServerOption {

// ServeGRPC implements the Handler interface.
func (s Server) ServeGRPC(grpcCtx context.Context, req interface{}) (context.Context, interface{}, error) {
ctx, cancel := context.WithCancel(s.ctx)
defer cancel()
ctx := s.ctx

// Retrieve gRPC metadata.
md, ok := metadata.FromContext(grpcCtx)
Expand Down
3 changes: 1 addition & 2 deletions transport/http/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ func ServerErrorLogger(logger log.Logger) ServerOption {

// ServeHTTP implements http.Handler.
func (s Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
ctx, cancel := context.WithCancel(s.ctx)
defer cancel()
ctx := s.ctx

for _, f := range s.before {
ctx = f(ctx, r)
Expand Down
3 changes: 1 addition & 2 deletions transport/httprp/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ func ServerBefore(before ...RequestFunc) ServerOption {

// ServeHTTP implements http.Handler.
func (s Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
ctx, cancel := context.WithCancel(s.ctx)
defer cancel()
ctx := s.ctx

for _, f := range s.before {
ctx = f(ctx, r)
Expand Down