Skip to content

Some small fixes on Profilesvc example #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterbourgon merged 2 commits into from
Jul 13, 2016
+4 −4
Merged

Some small fixes on Profilesvc example #318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197a9a4
Fix profilesvc path description
jygastaud Jul 12, 2016
08bcd22
Remove extra space
jygastaud Jul 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/profilesvc/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ func MakeHTTPHandler(ctx context.Context, s Service, logger log.Logger) http.Han
httptransport.ServerErrorEncoder(encodeError),
}

// POST /profiles adds another profile
// POST /profiles/ adds another profile
// GET /profiles/:id retrieves the given profile by id
// PUT /profiles/:id post updated profile information about the profile
// PATCH /profiles/:id partial updated profile information
// DELETE /profiles/:id remove the given profile
// GET /profiles/:id/addresses retrieve addresses associated with the profile
// GET /profiles/:id/addresses/ retrieve addresses associated with the profile
// GET /profiles/:id/addresses/:addressID retrieve a particular profile address
// POST /profiles/:id/addresses add a new address
// POST /profiles/:id/addresses/ add a new address
// DELETE /profiles/:id/addresses/:addressID remove an address

r.Methods("POST").Path("/profiles/").Handler(httptransport.NewServer(
Expand Down Expand Up @@ -276,7 +276,7 @@ func encodeGetAddressRequest(ctx context.Context, req *http.Request, request int
r := request.(getAddressRequest)
profileID := url.QueryEscape(r.ProfileID)
addressID := url.QueryEscape(r.AddressID)
req.Method, req.URL.Path = "GET", "/profiles/"+profileID+"/addresses/"+ addressID
req.Method, req.URL.Path = "GET", "/profiles/"+profileID+"/addresses/"+addressID
Copy link
Copy Markdown
Member

@peterbourgon peterbourgon Jul 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh! gofmt doesn't care either way. Interesting.

return encodeRequest(ctx, req, request)
}

Expand Down