Add unit tests for etcd Client#344
Merged
peterbourgon merged 2 commits intogo-kit:masterfrom Aug 23, 2016
Merged
Conversation
sync with go-kit/kit
| keysAPI: &fakeKeysAPI{event, err, getres}, | ||
| ctx: context.Background(), | ||
| }, nil | ||
| } |
Member
There was a problem hiding this comment.
No reason to have the return signature include an error that's always nil, unless I'm missing something?
func newFakeClient(...) Client {
return &client{...}
}
Contributor
Author
There was a problem hiding this comment.
True, I'll change that
Member
|
Other than that one nit, looks good! For the record: this increases coverage of package etcd from 35.1% to 68.9%. Here is the coverage report. Would you be up to adding some tests to registrar, too? ;) |
Contributor
Author
|
I'll have a look at registrar |
Member
|
78.4% 😎 |
Member
|
Amazing! Thank you so much. |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
Add unit tests for etcd Client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.