Remove service leftovers in consul integration test#371
Merged
peterbourgon merged 1 commit intomasterfrom Oct 4, 2016
Merged
Conversation
During a brief and forgotten period there was the Service abstraction which was used in the integration test of the Consul sd package. As it is guarded with a build tag it likely was missed, this change-set addresses this and removes all traces of the forgotten abstraction. Fixes #366
|
I confirmed that Glide can now scan the "github.com/go-kit/kit/sd/consul" import path without running into the previous error with not being able to find the "service" package. Thank you for fixing this. |
Member
|
😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a brief and forgotten period there was the Service abstraction which was used in the integration test of the Consul sd package. As it is guarded with a build tag it likely was missed, this change-set addresses this and removes all traces of the forgotten abstraction.
Fixes #366