shipping: Update with upstream changes#388
Merged
peterbourgon merged 2 commits intogo-kit:masterfrom Nov 9, 2016
marcusolsson:shipping-example-upstream-changes
Merged
shipping: Update with upstream changes#388peterbourgon merged 2 commits intogo-kit:masterfrom marcusolsson:shipping-example-upstream-changes
peterbourgon merged 2 commits intogo-kit:masterfrom
marcusolsson:shipping-example-upstream-changes
Conversation
Member
|
Can you rebase on master to get the tests green? |
Author
|
Done. |
jamesgist
pushed a commit
to jamesgist/kit
that referenced
this pull request
Nov 1, 2024
…ream-changes shipping: Update with upstream changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the shipping examples with some changes made upstreams in goddd.
repositorypackage renamed toinmemto better reflect what it provides.Locationstruct is a DDD Entity but was used as a Value Object. Other domain objects now refer to it by identity (UNLocode) instead of value.mockpackage with mock implementations of the repositories. Questionable if this should be added to the example, since the tests have been excluded in the shipping example. I think it's still interesting to show how it compares to theinmemrepository, but I have no problems leaving it out.P.S. Bulk changes are bad and I should feel bad. Let me know if you want me to split it.