Ber errors #168
Merged
Ber errors #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liggitt
reviewed
May 29, 2018
| } | ||
|
|
||
| func addControlDescriptions(packet *ber.Packet) { | ||
| func addControlDescriptions(packet *ber.Packet) error { |
Contributor
There was a problem hiding this comment.
aren't descriptions advisory/optional? I'm trying to decide is failing to add them should be a fatal error
Contributor
Author
There was a problem hiding this comment.
Failing means the packet is not in a valid format. This is just called (directly or indirectly) from addLDAPDescriptions which returns an error on broken packets (e.g. not enough children in a sequence).
liggitt
reviewed
May 30, 2018
dn.go
Outdated
| @@ -1,3 +1,7 @@ | |||
| // Copyright 2015 The Go Authors. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
Not sure where this copyright header came from
Contributor
|
remove copyright header and squash, then lgtm |
functions which were using ber.DecodePacket() now return an error also. fixes go-ldap#77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions which were using ber.DecodePacket() now return an error also.
fixes #77