Add DIGEST-MD5 bind support #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnweldon
reviewed
Oct 22, 2019
Member
johnweldon
left a comment
johnweldon
left a comment
There was a problem hiding this comment.
Thanks for this PR.
Would you be willing to refactor this per the recent PR that also added other Bind mechanisms, and unified some of the internal flow?
Additionally, some tests/examples/documentation would be welcome too.
Contributor
Author
|
Changed the DigestMD5BindRequest.appendTo function to satisfy the request interface. |
johnweldon
requested changes
Feb 4, 2020
Member
johnweldon
left a comment
johnweldon
left a comment
There was a problem hiding this comment.
Looks good with a minor change that needs to be reverted.
go.mod
Outdated
| @@ -1,5 +1,8 @@ | |||
| module github.com/go-ldap/ldap | |||
| module github.com/microo8/ldap | |||
johnweldon
approved these changes
Feb 5, 2020
Member
johnweldon
left a comment
johnweldon
left a comment
There was a problem hiding this comment.
Thanks again @microo8
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not the most elegant code, but it works for me :)