Examples appear in the documentation #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnweldon
requested changes
Dec 12, 2019
Member
johnweldon
left a comment
johnweldon
left a comment
There was a problem hiding this comment.
Thanks for this PR.
This will resolve #253.
I don't want to lose all that code documentation entirely - what do you think about consolidating it all in a documentation text file?
Contributor
Author
|
@johnweldon thanks for the review. I've added links to specifications the library implements. I don't see any reason to copy the content of specifications into go files. |
regeda
force-pushed
the
update-documentation
branch
from
b252037 to
1bf3a08
Compare
regeda
force-pushed
the
update-documentation
branch
from
1bf3a08 to
62a535c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the PR in order to make the library godoc very helpful: