-
Notifications
You must be signed in to change notification settings - Fork 371
Add extensibleMatch filter support, fix multi-byte filters #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored so that substring and extensible match filters can reuse this
|
@johnweldon please take a look |
|
Tested against a live LDAP server with the following extensions: Search filters were accepted as valid, and behavior indicated extension was passed successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case you want to verify the old bytes were wrong, and the new bytes are right: http://play.golang.org/p/GeNmpuSEs7
|
What behavior will this have for nested groups? |
|
It lets you tell the AD server you want it to flatten membership for you, rather than recursing yourself |
|
LGTM, |
Add extensibleMatch filter support, fix multi-byte filters
Fixes #28
Fixes #39