test: remove time-based checking #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 田原 <tianyuan@pingcap.cn>
There was a problem hiding this comment.
PR Overview
This PR removes time-based checks in cache tests and replaces them with a counter-based mechanism to verify that caching is effective.
- Removed timing-based measurements from TestCachingSha2Cache and TestCachingSha2CacheTLS.
- Introduced an atomic counter (getCredCallCnt) in RemoteThrottleProvider to confirm that GetCredential is called only once.
- Updated tests to assert the new counter value after establishing connections.
Reviewed Changes
| File | Description |
|---|---|
| server/caching_sha2_cache_test.go | Replaced delay-based timing checks with an atomic counter verification mechanism. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
server/caching_sha2_cache_test.go:63
- [nitpick] Consider renaming 'getCredCallCnt' to 'getCredCallCount' for improved clarity.
getCredCallCnt atomic.Int64
|
@dveeden PTAL |
dveeden
approved these changes
Mar 3, 2025
Signed-off-by: lance6716 <lance6716@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #988
check a counter to verify cache really takes effect