Skip to content

feat: removing short cicuit in client use db #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lance6716 merged 3 commits into from
Dec 6, 2025
Merged

feat: removing short cicuit in client use db #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06fe54b
feat: adding force use db in client conn
vanhtuan0409 Nov 27, 2025
b088707
fix: just remove the short circuit all together
vanhtuan0409 Nov 28, 2025
9f0f3d6
add unit test
lance6716 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions client/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,6 @@ func (c *Conn) SetTLSConfig(config *tls.Config) {
}

func (c *Conn) UseDB(dbName string) error {
if c.db == dbName {
return nil
}

if err := c.writeCommandStr(mysql.COM_INIT_DB, dbName); err != nil {
return errors.Trace(err)
}
Expand Down
27 changes: 27 additions & 0 deletions client/conn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,30 @@ func (s *connTestSuite) TestSetQueryAttributes() {
}
require.Equal(s.T(), expected, s.c.queryAttributes)
}

func (s *connTestSuite) TestUseDB() {
_, err := s.c.Execute("create database if not exists proxier;")
require.NoError(s.T(), err)
err = s.c.UseDB("proxier")
require.NoError(s.T(), err)
result, err := s.c.Execute("select database();")
require.NoError(s.T(), err)
value, err := result.GetString(0, 0)
require.NoError(s.T(), err)
require.Equal(s.T(), "proxier", value)
_, err = s.c.Execute("drop database proxier;")
require.NoError(s.T(), err)
_, err = s.c.Execute("create database proxier;")
require.NoError(s.T(), err)
err = s.c.UseDB("proxier")
require.NoError(s.T(), err)
result, err = s.c.Execute("select database();")
require.NoError(s.T(), err)
value, err = result.GetString(0, 0)
require.NoError(s.T(), err)
require.Equal(s.T(), "proxier", value)
_, err = s.c.Execute("drop database proxier;")
require.NoError(s.T(), err)
err = s.c.UseDB("test")
require.NoError(s.T(), err)
}
Loading