client: Have SetCapability() return an error for unsupported caps #1077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to: #1074 (comment)
Example code
Output:
Note that we could:
CapabilityString()(This is in the other PR, mysql,client: add log for caps we can't set #1074 )UnsetCapability()also return an error. But without any real checking for now. Just to keep the signature similarSetCapability(mysql.CLIENT_PROTOCOL_41)and other base capabilities (opposed to optional capabilities) be accepted without error. Or have an error like "can not set capability that is already set".SetCapability()return errors when setting optional capabilities that are already set.