Skip to content

Install latest patch version if major.minor semantic version provided; Add latest command to install#252

Merged
syndbg merged 5 commits intogo-nv:masterfrom
ChronosMasterOfAllTime:use_latest_patch
Oct 16, 2022
Merged

Install latest patch version if major.minor semantic version provided; Add latest command to install#252
syndbg merged 5 commits intogo-nv:masterfrom
ChronosMasterOfAllTime:use_latest_patch

Conversation

@ChronosMasterOfAllTime
Copy link
Copy Markdown
Contributor

@ChronosMasterOfAllTime ChronosMasterOfAllTime commented Oct 12, 2022

Should resolve the ask in #121.

Adds:

goenv install latest
goenv install unstable

if the semantic version is only supplied with major/minor, find the latest patch version and use that for install.

e.g. if 1.19 is supplied and the following versions are available:

1.19.0
1.19.1
1.19.2

1.19.2 will be installed

Added unit tests to validate functionality

Copy link
Copy Markdown
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking already pretty good: I just left a feed comments that have more to do with long-term maintenance than anything else.

Plus, if I got the regexp right, I think you are intending to match "latest" version to also "beta" and "rc" releases, and I don't think it's a great idea. But I'm not the owner of the repo, so I'd leave it to @syndbg and other maintainers to make the call.

Personally, I think the vast majority of users want a tool that lets them easily switch version of go, while they move across their repositories/projects. Those people are rarely interested in non-stable versions of Go.

@ChronosMasterOfAllTime
Copy link
Copy Markdown
Contributor Author

This is looking already pretty good: I just left a feed comments that have more to do with long-term maintenance than anything else.

Plus, if I got the regexp right, I think you are intending to match "latest" version to also "beta" and "rc" releases, and I don't think it's a great idea. But I'm not the owner of the repo, so I'd leave it to @syndbg and other maintainers to make the call.

Personally, I think the vast majority of users want a tool that lets them easily switch version of go, while they move across their repositories/projects. Those people are rarely interested in non-stable versions of Go.

Addressed all comments @detro

@ghost
Copy link
Copy Markdown

ghost commented Oct 12, 2022

Awesome!

Copy link
Copy Markdown
Contributor

@detro detro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good.

@ghost
Copy link
Copy Markdown

ghost commented Oct 13, 2022

@syndbg This looks ready to merge; tests all passed

@syndbg syndbg merged commit 21cc9a2 into go-nv:master Oct 16, 2022
@ChronosMasterOfAllTime ChronosMasterOfAllTime deleted the use_latest_patch branch October 30, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants