Adaptation for BSD on amd64 arch. & Fixed typo for BSD on 32 bit arch.#44
Merged
syndbg merged 2 commits intogo-nv:masterfrom May 14, 2018
Merged
Adaptation for BSD on amd64 arch. & Fixed typo for BSD on 32 bit arch.#44syndbg merged 2 commits intogo-nv:masterfrom
syndbg merged 2 commits intogo-nv:masterfrom
Conversation
Fixed typo for installing bsd 32 bit.
There are amd64 bsd machines.
Member
|
Thank you for the PR, I'll review it within today (European Central Time)! |
Member
|
I took my sweet time, sorry for the wait! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my machine
uname -mreturnsamd64so I fixed logic for determining architecture inplugins/go-build/bin/go-buildespecially in BSD-related function. It may be suggested to add similar architecture determining code for other OS.In addition I fixed trivial typo.