Fix LC_ALL being overwritten by goenv, breaking TUI apps and locale-dependent programs #489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goenvwas settingexport LC_ALL=Cglobally to optimize grep performance, but this leaked to all child processes executed through shims, overwriting users' locale settings and breaking applications that depend on proper locale configuration (e.g., TUI apps, Unicode handling).Changes
libexec/goenvLC_ALLvalue at script startuprestore_lc_all()function to restore original value (or unset if not previously set)restore_lc_all()before allexecstatements to isolateLC_ALL=Cto the goenv process onlytest/goenv-exec.batsLC_ALLis preserved when setLC_ALLremains unset when not previously setImpact
The fix preserves
LC_ALL=Cfor goenv's internal grep operations while ensuring child processes inherit the user's original locale settings.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.