Skip to content

Conversation

@zonghuili2019
Copy link

redefine tgr

@Cyberhan123
Copy link

yes, I got same

}

tgr := &oauth2.TokenGenerateRequest{
tgr = &oauth2.TokenGenerateRequest{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect. 👌

@MilanSavaliya
Copy link

MilanSavaliya commented Jul 3, 2021

I think it would be good if you can merge this as soon as possible.

@derekbassett @arran4 @vgarvardt ?

@arran4
Copy link
Contributor

arran4 commented Jul 3, 2021

Hey, I don't have write access to the repo sorry.

@LyricTian LyricTian merged commit 83534bf into go-oauth2:master Jul 6, 2021
@MilanSavaliya
Copy link

@LyricTian is it possible to create new version tag and make it available ?

@Cyberhan123
Copy link

@LyricTian is it possible to create new version tag and make it available ?

May not, It's an hot fix ,so version tag may an bad idea. cc @LyricTian How do you see?

@novrian
Copy link

novrian commented Jul 16, 2021

@Cyberhan123 v4 is broken right now.
If it's not possible to create a new tag then how can we use v4?

@Cyberhan123
Copy link

Cyberhan123 commented Jul 16, 2021

@Cyberhan123 v4 is broken right now.
If it's not possible to create a new tag then how can we use v4?

It just a package cache, U can run
go clean -i -n github.com/go-oauth2/oauth2/v4/...
uninstall it (some dir may should delete by hand) and go get fetch it again

@novrian
Copy link

novrian commented Jul 16, 2021

Screen Shot 2021-07-16 at 14 08 11

@Cyberhan123 no luck, still experience the same error

nevermind, maybe I will use v3 either. thanks for helping han

@MilanSavaliya
Copy link

MilanSavaliya commented Jul 16, 2021

@Cyberhan123 @LyricTian i think this will not work as releases are tied with particular commit hash as you can see in attached picture. You have to create newer tag release to offer this fix.

image

@Cyberhan123
Copy link

Cyberhan123 commented Jul 17, 2021

@cyber​​han123 @LyricTian我认为这不会起作用,因为发布与特定的提交哈希相关联,如您在附图中所见。您必须创建更新的标签版本才能提供此修复程序。

图像

屏幕截图 2021-07-16 at 14 08 11

@cyber​​han123不走运,仍然遇到同样的错误

没关系,也许我也会使用 v3。谢谢你帮助韩

@Cyberhan123 @LyricTian i think this will not work as releases are tied with particular commit hash as you can see in attached picture. You have to create newer tag release to offer this fix.

image

oh, you are right and I want check out why my packge are worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants