Conversation
…namic FederationEntity interfaces with improved configuration handling
zachmann
changed the title
Contributor
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage  |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Mar 31, 2026 1:33p.m. | Review ↗ |
| Test coverage |  |
Mar 31, 2026 1:33p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 4.6% |
44.3% [▼ down 3.4% from main] |
| Go | 4.6% |
44.3% [▼ down 3.4% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
…s; add shared rotation helpers; refactor rotation logic
…rate legacy support to dedicated helpers
…log statements for consistency
… fields and improve SQL compatibility
… public key storage operations
…rithm changes with future-dated keys
…arks and JWKS expiration
…centralized trust mark info retrieval
…-memory implementation; refactor TrustMarkIssuer to support configurable spec providers
# Conflicts: # go.mod # go.sum
…ions (SlotNumber, MaxSessions, UserType, LoginNotSupported, PoolWaitTimeout)
# Conflicts: # go.mod
…on, key serialization, JWKS operations, and JWT signing
…ity validation, trustmark issuer JWKS, multiple trustmarks, and delegated trustmarks
…cer, including edge cases, error handling, and extended scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…namic FederationEntity interfaces with improved configuration handling