Skip to content

chore: dead-code removal#17

Merged
fredbi merged 1 commit intogo-openapi:masterfrom
fredbi:chore/remove-dead-code
Apr 19, 2026
Merged

chore: dead-code removal#17
fredbi merged 1 commit intogo-openapi:masterfrom
fredbi:chore/remove-dead-code

Conversation

@fredbi
Copy link
Copy Markdown
Member

@fredbi fredbi commented Apr 19, 2026

  • removed dead-code (added justification comments)
  • added unit tests (now using mocks)
  • removed misleading comments or "TODO" mentions that will never get done

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

* removed dead-code (added justification comments)
* added unit tests (now using mocks)
* removed misleading comments or "TODO" mentions that will never get
  done

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.19%. Comparing base (7262605) to head (429f2c6).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/builders/schema/schema.go 36.36% 7 Missing ⚠️
internal/builders/items/typable.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage   71.79%   87.19%   +15.39%     
===========================================
  Files          48       43        -5     
  Lines        4878     3958      -920     
===========================================
- Hits         3502     3451       -51     
+ Misses       1148      314      -834     
+ Partials      228      193       -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi merged commit 8500f21 into go-openapi:master Apr 19, 2026
20 of 21 checks passed
@fredbi fredbi deleted the chore/remove-dead-code branch April 19, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant