fix: Content-Type of 404 & 405 responses #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes go-openapi#372 If a specification contains a default producer Content-Type and at least one route with a specific (and different) producer Content-Type, the Content-Type of 405 and 404 responses was this specific Content-Type. Now the default producer Content-Type is always used. Signed-off-by: Maxime Soulé <btik-git@scoubidou.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 78.28% 78.29%
=======================================
Files 50 50
Lines 3371 3372 +1
=======================================
+ Hits 2639 2640 +1
Misses 623 623
Partials 109 109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fredbi
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372
If a specification contains a default producer Content-Type and at least one route with a specific (and different) producer Content-Type, the Content-Type of 405 and 404 responses was this specific Content-Type.
Now the default producer Content-Type is always used.