chore: disabled goconst linter#271
Merged
Merged
Conversation
goconst has been "improved" lately and has actually become too noisy. It used to be useful, but now it is just trying to nudge us into transforming every thing into a const. This is not really helping our codebase. We disable it entirely until we find a way to figure out more effective settings for this linter. Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 86.50% 86.50%
=======================================
Files 18 18
Lines 2467 2467
=======================================
Hits 2134 2134
Misses 230 230
Partials 103 103 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goconst has been "improved" lately and has actually become too noisy. It used to be useful, but now it is just trying to nudge us into transforming every thing into a const. This is not really helping our codebase.
We disable it entirely until we find a way to figure out more effective settings for this linter.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist