feat: eventually with / CollecT#90
Merged
fredbi merged 1 commit intogo-openapi:masterfrom Apr 15, 2026
Merged
Conversation
fredbi
force-pushed
the
fix/eventuallyWith
branch
from
da9e5f4 to
b5ff5ba
Compare
* fix(condition): in async testing, allow condition goroutine to exit
* allows condition to Goexit without exiting the whole assertion
* feat(condition): CollectT now distinguishes between FailNow() and Cancel()
* FailNow() exits the condition, Cancel() interrupts the whole
assertion
* regenerated code with examples and doc strings
* fixes go-openapi#90
Follow-up PRs:
1. Update documentation and code examples
2. Enhance / better report to user in migration tool
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
fix/eventuallyWith
branch
from
b5ff5ba to
e53eb5b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 91.32% 91.28% -0.05%
==========================================
Files 93 93
Lines 12041 12056 +15
==========================================
+ Hits 10997 11005 +8
- Misses 829 836 +7
Partials 215 215 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist