Revert "fix: *string(nil) not equal &string #152" #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuker
approved these changes
Nov 28, 2023
Author
This reverts commit 348543c. Signed-off-by: Vlad Gogolev <v.gogolev@uzum.com>
tomaszmrugalski
pushed a commit
to isc-projects/stork
that referenced
this pull request
Nov 30, 2023
Avoiding issue go-openapi/validate#159.
casualjim
approved these changes
Dec 1, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 90.67% 90.67% -0.01%
==========================================
Files 22 22
Lines 2991 2980 -11
==========================================
- Hits 2712 2702 -10
+ Misses 226 225 -1
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 348543c.
Fix for issue: #158