Skip to content

Fix dev oauth#6

Closed
Reeywhaar wants to merge 2 commits intogo-pkgz:masterfrom
Reeywhaar:fix-dev-oauth
Closed

Fix dev oauth#6
Reeywhaar wants to merge 2 commits intogo-pkgz:masterfrom
Reeywhaar:fix-dev-oauth

Conversation

@Reeywhaar
Copy link
Copy Markdown
Contributor

To #5 (comment)
The layout is completely broken, because of go Sprintf interpolation. Percent marks in css caused the issue.
I don't know should I fix it myself, maybe you know how make it better, but anyway.

@umputun
Copy link
Copy Markdown
Member

umputun commented Dec 29, 2018

I'll make it html/template, should work

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 57

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.189%

Totals Coverage Status
Change from base Build 56: 0.2%
Covered Lines: 960
Relevant Lines: 1154

💛 - Coveralls

umputun added a commit that referenced this pull request Dec 30, 2018
@umputun
Copy link
Copy Markdown
Member

umputun commented Dec 30, 2018

@Reeywhaar I have changed to template, so no need for the conflicting fix

@Reeywhaar Reeywhaar closed this Dec 30, 2018
@Reeywhaar Reeywhaar deleted the fix-dev-oauth branch December 30, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants