Skip to content

Fixed bug with body close at Apple provider#88

Merged
umputun merged 1 commit intogo-pkgz:masterfrom
zebox:master
May 27, 2021
Merged

Fixed bug with body close at Apple provider#88
umputun merged 1 commit intogo-pkgz:masterfrom
zebox:master

Conversation

@zebox
Copy link
Copy Markdown
Contributor

@zebox zebox commented May 27, 2021

Defer func with Body.Close() called after an error check. If an error occurred defer never called and file descriptors could been leaking. I moved defer block above error check for fix that.

@zebox zebox requested a review from umputun as a code owner May 27, 2021 18:28
@umputun umputun merged commit 99f2d83 into go-pkgz:master May 27, 2021
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 883162165

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.217%

Totals Coverage Status
Change from base Build 867017874: 0.0%
Covered Lines: 219
Relevant Lines: 230

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants