Skip to content

Conversation

@codemageddon
Copy link
Contributor

@codemageddon codemageddon commented Mar 28, 2025

This pull request fixes a missing strings package import in the generated code when running the generation without the -lower flag.

@codemageddon codemageddon requested a review from umputun as a code owner March 28, 2025 20:50
@umputun umputun requested a review from Copilot March 28, 2025 21:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the "strings" package was not imported during code generation when the -lower flag was not used.

  • Added a conditional import for the "strings" package in the generator.
  • Ensured that the generated code compiles correctly with the proper imports.

Copy link
Member

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@umputun umputun merged commit 6b9cf3c into go-pkgz:master Mar 28, 2025
2 checks passed
@codemageddon codemageddon deleted the fix-missing-import-wo-lower-flag branch April 1, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants