V6 development #115
Merged
V6 development #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
investigation if goroutines in a consumer producer pattern vs passing a map Spoiler: the map wins out big time!
…or.v5 into v5-development
whether it's a struct field or just a regular field working on a single function to handle both to reduce checking the same values within struct field recursion or a regular field; this will also help reduce code complexity and keep things DRY.
V5 development
updated baked in functions: hasLengthOf isGt isGte isLt isLte to use utf8.RuneCountInString for string length comparisons, not counting multi-bye characters but runes in string length comparisons.
update to use utf8.RuneCountInString for string length
update string comparisons to use utf8.RuneCountInString
initial function layouts and validation completed, still need to rework all of the baked in functions, add map and array traversal and add back original test cases. NOTE: a far more pragmatic validation tests will be added, but not until it has been proven stable with at least the old tests.
added single field validation function. updated a few more baked in functions. added back single field validation benchmark.
completed all validations function conversion. updated omitempty check to continue if all ok instead of passing tag to be validated.
updating test for the new error return formet updated assertion functions to handle a nil Map,Slice,Ptr.....type fixed hasValue check not comparing Interface but field Value.
Updated all tests to comply with new api. Fix a few bugs found with validation.
Renamed for better clarity. Added Field OrTag Benchmark.
was just keeping around for reference when converting.
when no errors occur, let's reuse the existing object.
now the benchmarks are getting back to awesome!
V6 development
Change CI to Semaphore
fairyhunter13
added a commit
to fairyhunter13/validator
that referenced
this pull request
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.